-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced recovery system BIOS boot default settings for USB and ISO (related to issue 2276 #2303
Conversation
@rear/contributors |
@jsmeix this functionality is useful (cc @chlupnoha who will probably make use of it), but shouldn't it be an opportunity to unify those settings? Why to have one option for USB disks, another for CD images, when both do essentially the same thing? Even why to distinguish BIOS and UEFI? I propose just |
@pcahyna Regarding why to distinguish BIOS and UEFI? My personal answer from my (non booting expert) point of view is: For example I wonder if Perhaps someting more generic like Is "boot disk enumeration" a really meaningful concept for UEFI? For example on my openSUSE Leap 15.0 system I get
So the I think when one has UEFI firmware with legacy BIOS support Also in my above example the Regarding I noticed that special config variable "by accident" while I was Also here my personal assumtion is that the reason behind is A generic functionality to provide predefined ReaR recovery system What is implemented in ReaR is only a single separated special case The current generic way for such things is that the user must Finally: At least some of the above is again the same old consequence The whole USB stuff is basically some kind of "add-on hack" Cf. |
@chlupnoha |
Now it is after-noon... |
I had also tested the ISO case and it worked for me. |
Type: Enhancement
Impact: Low
Reference to related issue (URL):
How to modify recovery system UEFI bootloader to boot the "normal" system by default? #2276 (comment)
How was this pull request tested?
Currently I had only tested the USB case.
I need to test the ISO case.
Brief description of the changes in this pull request:
For
OUTPUT=ISO
the user can now explicitly specifywhat to boot by default when booting the ISO on BIOS systems via
ISO_DEFAULT="boothd0"
to boot from the first disk andISO_DEFAULT="boothd1"
to boot from the second disk.For
OUTPUT=USB
the user can now explicitly specifywhat to boot by default when booting the disk on BIOS systems via
USB_BIOS_BOOT_DEFAULT="boothd0"
to boot from the first disk.The default
USB_BIOS_BOOT_DEFAULT=""
boots the second disk.Those things are now (hopefully correctly) explained in default.conf
Additionally usr/share/rear/conf/templates/rear.help
is now plain ASCII according to "Character encoding" in
https://github.com/rear/rear/wiki/Coding-Style
to avoid that this text may show unexpected when the
SYSLINUX boot stuff is shown to the user on whatever
possibly unusual remote console or on whatever special
system management user interface (I had some personal
"interesting user experience" with some Java based tingy ;-)